Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: exit native with error value on failure #20445

Merged
merged 5 commits into from
Mar 4, 2024
Merged

tests: exit native with error value on failure #20445

merged 5 commits into from
Mar 4, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 4, 2024 •
edited
Loading

Contribution description

When no more threads are running, we can exit native for all tests.
In this case, also return _native_retval instead of EXIT_SUCCESS.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: tests Area: tests and testing framework Area: cpu Area: CPU/MCU ports Area: sys Area: System labels Mar 4, 2024
@benpicco benpicco changed the title tests: exit with error value on failure tests: exit native with error value on failure Mar 4, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 4, 2024
@riot-ci
Copy link

riot-ci commented Mar 4, 2024 •
edited
Loading

Murdock results

✔️ PASSED

b274e8a tests/unittests: report results to the environment on native

Success Failures Total Runtime
10009 0 10009 07m:25s

Artifacts

@benpicco benpicco force-pushed the cpu/native-AUTO_EXIT branch from 54583d1 to b274e8a Compare March 4, 2024 13:44
@github-actions github-actions bot added the Area: core Area: RIOT kernel. Handle PRs marked with this with care! label Mar 4, 2024
derMihai added a commit to derMihai/RIOT that referenced this pull request Mar 4, 2024
@derMihai
rewrite for EmbUnit. TODO: rebase on RIOT-OS#20445
867c18c
@riot-ci riot-ci mentioned this pull request Mar 4, 2024
Merged
@benpicco benpicco added this pull request to the merge queue Mar 4, 2024
Merged via the queue into RIOT-OS:master with commit 31d2300 Mar 4, 2024
26 checks passed
@benpicco benpicco deleted the cpu/native-AUTO_EXIT branch March 4, 2024 17:01
@benpicco benpicco mentioned this pull request Apr 3, 2024
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @kaspar030 @MrKevinWeiss